Conversation
|
Hi @ahmad753 I'm not sure this fixes anything, can you explain more what you're trying to solve? |
|
@alecritson This commit "Fix basket line reward apply" And for this commit "Fix issues in discount" the removed line its not functioning, so I increment the discount from its set. |
|
|
||
| foreach ($this->discounts->get() as $discount) { | ||
| foreach ($discount->rewards as $reward) { | ||
| $method = 'apply'.ucfirst($reward->type); |
There was a problem hiding this comment.
Could you just change it to Str::camelCase and ucfirst so fixed_amount becomes FixedAmount?
There was a problem hiding this comment.
I think this would be better, although I appreciate this PR is quite old now so might need revisiting in full.
No description provided.